[libvirt] [PATCH 15/23] Don't ignore errors parsing nwfilter rules
Eric Blake
eblake at redhat.com
Wed Sep 25 16:47:33 UTC 2013
On 09/25/2013 08:51 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> For inexplicable reasons, the nwfilter XML parser is intentionally
> ignoring errors that arise during parsing. As well as meaning that
> users don't get any feedback on their XML mistakes, this will lead
> it to silently drop data in OOM conditions.
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> src/conf/nwfilter_conf.c | 16 ++++++++--------
> tests/nwfilterxml2xmltest.c | 14 ++++++--------
> 2 files changed, 14 insertions(+), 16 deletions(-)
ACK 12-15.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130925/1f34d50e/attachment-0001.sig>
More information about the libvir-list
mailing list