[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix crash in libvirtd when events are registered & ACLs active



On 09/27/2013 09:26 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> When a client disconnects from libvirtd, all event callbacks
> must be removed. This involves running the public API
> 
>   virConnectDomainEventDeregisterAny
> 
> This code does not run in normal API dispatch context, so no
> identity was set. The result was that the access control drivers
> denied the attempt to deregister callbacks. The callbacks thus
> continued to trigger after the client was free'd causing fairly
> predictable use of free memory & a crash.
> 
> This can be triggered by any client with readonly access when
> the ACL drivers are active.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  daemon/remote.c | 6 ++++++
>  1 file changed, 6 insertions(+)

ACK; affects 1.1.0 onwards.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]