[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] LXC: workaround machined uncleaned data with containers running systemd.



On Mon, Sep 30, 2013 at 04:46:29PM +0200, Cédric Bosdonnat wrote:
> The problem is described by [0] but its effect on libvirt is that
> starting a container with a full distro running systemd after having
> stopped it simply fails.
> 
> The container cleanup now calls the machined Terminate function to make
> sure that everything is in order for the next run.
> 
>  [0]: https://bugs.freedesktop.org/show_bug.cgi?id=68370
> ---
>  src/libvirt_private.syms |  2 ++
>  src/lxc/lxc_process.c    |  8 +++++
>  src/util/virsystemd.c    | 80 +++++++++++++++++++++++++++++++++++++++++-------
>  src/util/virsystemd.h    |  8 +++++
>  tests/virsystemdtest.c   | 28 +++++++++++++++++
>  6 files changed, 117 insertions(+), 12 deletions(-)
> 
> 2nd version:
>  * Removed the Makefile hack and added symbols to libvirt_private.syms instead
>  * Added virSystemdMakeMachineName to factorize some code in Make and Terminate
>    machine systemd functions.
>  * Added tests for TerminateMachine and TerminateContainer cases

ACK and pushed since this is a critical fix for systemd hosts.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]