[libvirt] [PATCH v2]lxc: do cleanup when failed to bind fs as read-only

Eric Blake eblake at redhat.com
Mon Sep 30 19:37:57 UTC 2013


On 09/30/2013 01:29 PM, Eric Blake wrote:
> On 09/30/2013 03:06 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>>
>> We forgot to do cleanup when lxcContainerMountFSTmpfs
>> failed to bind fs as read-only.
>>
>> v2: fix an indentation issue

Oh, and a side note.  Patch changelogs, such as this paragraph...

>>
>> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>> ---

...belong here, after the ---, so that 'git am' won't make them part of
the permanent git history.  They're highly useful to reviewers, but not
so much when revisiting the code a year from now when we don't care how
many iterations it took to get to a final patch.

> 
> ACK and pushed.

so I amended before actually pushing.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130930/f3191751/attachment-0001.sig>


More information about the libvir-list mailing list