[libvirt] [PATCH] tests: build viridentitytest only WITH_ATTR.

Nehal J Wani nehaljw.kkd1 at gmail.com
Sat Apr 5 03:17:17 UTC 2014


On Fri, Apr 4, 2014 at 6:57 PM, Jincheng Miao <jmiao at redhat.com> wrote:
> Commit d7c4e0036 assumed all SELinux tests depended upon
> securityselinuxhelper need xattr support, but forgot to
> move viridentitytest under WITH_ATTR.
>
> Reported-by: Nehal J Wani <nehaljw.kkd1 at gmail.com>
> Signed-off-by: Jincheng Miao <jmiao at redhat.com>
> ---
>  tests/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 6e15af8..7a15295 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -146,7 +146,6 @@ test_programs = virshtest sockettest \
>         virpcitest \
>         virendiantest \
>         virfiletest \
> -       viridentitytest \
>         viriscsitest \
>         virkeycodetest \
>         virlockspacetest \
> @@ -188,7 +187,8 @@ endif WITH_DBUS
>
>  if WITH_SECDRIVER_SELINUX
>  if WITH_ATTR
> -test_programs += securityselinuxtest
> +test_programs += securityselinuxtest \
> +                 viridentitytest
>  if WITH_QEMU
>  test_programs += securityselinuxlabeltest
>  endif WITH_QEMU
> --
> 1.8.3.1
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list


ACK

-- 
Nehal J Wani




More information about the libvir-list mailing list