[libvirt] [PATCHv2] Fix coverity-reported leak in virSecurityManagerGenLabel

Eric Blake eblake at redhat.com
Wed Apr 2 14:26:51 UTC 2014


On 04/02/2014 07:26 AM, Ján Tomko wrote:
> Coverity complains about a possible leak of seclabel if
> !sec_managers[i]->drv->domainGenSecurityLabel is true
> and the seclabel might be overwritten by the next iteration
> of the loop.
> 
> This leak should never happen, because every security driver
> has domainGenSecurityLabel defined.
> ---
> v1: 'Remove useless NULL check in virSecurityManagerGenLabel'
> https://www.redhat.com/archives/libvir-list/2014-April/msg00087.html

ACK, and nicer that it is smaller.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140402/d210b6cb/attachment-0001.sig>


More information about the libvir-list mailing list