[libvirt] [PATCH 5/5] conf: start testing contents of the new backing chain fields

Peter Krempa pkrempa at redhat.com
Fri Apr 4 10:02:11 UTC 2014


On 04/04/14 06:32, Eric Blake wrote:
> The testsuite is absolutely essential to feeling comfortable
> about swapping the backing chain structure over to a new format.
> This patch tests the path settings, and demonstrates that right
> now the code is passing only the canonical name to the child
> struct, which means more work is necessary in virstoragefile
> to pass the user spelling alongside the canonical name down to
> the child.
> 
> * tests/virstoragetest.c (testStorageChain): Test path.
> (mymain): Update expected data.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  tests/virstoragetest.c | 239 ++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 175 insertions(+), 64 deletions(-)
> 

Looks reasonable. ACK.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140404/c621f06b/attachment-0001.sig>


More information about the libvir-list mailing list