[libvirt] [PATCH 4/5] conf: interleave virstoragetest structs
Peter Krempa
pkrempa at redhat.com
Mon Apr 7 09:04:55 UTC 2014
On 04/06/14 05:32, Eric Blake wrote:
> As I add more tests, it's getting harder to follow the split between
> a struct in one place and a test using the struct in another.
> Interleaving the tests makes changes more localized, and also makes
> debugging easier when a test goes wrong during my refactoring work.
>
> * tests/virstoragetest.c (mymain): Modify structs as we go, rather
> than up-front.
> (testStorageChain): Make failure debugging easier.
>
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> tests/virstoragetest.c | 331 ++++++++++++++++++++++---------------------------
> 1 file changed, 145 insertions(+), 186 deletions(-)
>
ACK,
the original structs also were locals in mymain, thus this patch doesn't
change stack space requirements for that function.
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140407/d84b76b4/attachment-0001.sig>
More information about the libvir-list
mailing list