[libvirt] [PATCH 2/3] tests: Only use privileged mode if Qemu user and group exists
Guido Günther
agx at sigxcpu.org
Tue Apr 8 15:35:52 UTC 2014
On Tue, Apr 08, 2014 at 07:27:06AM -0600, Eric Blake wrote:
> On 04/08/2014 07:06 AM, Guido Günther wrote:
>
> >>> What about passing 'false' to ConfigNew() but then manually
> >>> set 'cfg->privileged = true' on the object we get back.
> >>>
> >>
> >> That could work. All tests passed on my setup like that. And it
> >> doesn't seem weird since we're playing with the config a lot in the
> >> tests.
> >
> > I do wonder if my approach wouldn't be cleaner since it doesn't poke
> > into the objects internals.
>
> Your approach skips the test, which means less testsuite coverage. I'd
> rather poke into internals to make the testsuite independent of the
> environment while still maximizing coverage.
O.k. then, ACK.
-- Guido
More information about the libvir-list
mailing list