[libvirt] [PATCH] tests: Fix systemd test with --without-driver-modules

Jiri Denemark jdenemar at redhat.com
Fri Apr 11 08:21:43 UTC 2014


On Thu, Apr 10, 2014 at 11:02:02 -0600, Eric Blake wrote:
> On 04/10/2014 09:26 AM, Jiri Denemark wrote:
> > Every test that makes use of virmock.h (only virsystemdtest as of now)
> > needs to be linked with -export-dynamic to make sure the LD_PRELOADed
> > mock library can access it's wrap_* symbols. Normally,
> > DRIVER_MODULE_LDFLAGS variable contains -export-dynamic but when
> > --without-driver-modules configure option is used, DRIVER_MODULE_LDFLAGS
> > is empty.
> > 
> > This patch turns on -export-dynamic for all tests unconditionally
> > regardless on --without-driver-modules. This fixes virsystemdtest and
> > all future users of virmock.h.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> >  tests/Makefile.am | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> ACK.

Pushed, thanks.

Jirka




More information about the libvir-list mailing list