[libvirt] [PATCH 09/26] Remove two-stage construction of commands in nwfilter
Stefan Berger
stefanb at linux.vnet.ibm.com
Tue Apr 15 17:21:25 UTC 2014
On 04/08/2014 11:38 AM, Daniel P. Berrange wrote:
> The nwfilter ebiptables driver will build up commands to run in
> two phases. The first phase contains all of the command, except
> for the '-A' part. Instead it has a '%c' placeholder, along with
> a '%s' placeholder for a position arg. The second phase than
> substitutes these placeholders. The only values ever used for
> these substitutions though is '-A' and '', so it is entirely
> pointless. Remove the second phase entirely, since it will make
> it harder to convert to the new firewall APIs
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
ACK
More information about the libvir-list
mailing list