[libvirt] [PATCH] Remove QEMU_CAPS_MACHINE_USB_OPT from ComputeCmdFlags

Martin Kletzander mkletzan at redhat.com
Fri Apr 18 08:04:22 UTC 2014


On Thu, Apr 17, 2014 at 04:56:58PM +0200, Ján Tomko wrote:
>The version check is for >1.3.0, but ComputeCmdFlags
>is only called for QEMU older than 1.2.0.
>---
> src/qemu/qemu_capabilities.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>index 381b3ec..5814c7c 100644
>--- a/src/qemu/qemu_capabilities.c
>+++ b/src/qemu/qemu_capabilities.c
>@@ -1143,10 +1143,6 @@ virQEMUCapsComputeCmdFlags(const char *help,
>     if (strstr(help, "-machine"))
>         virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_OPT);
>
>-     /* USB option is supported v1.3.0 onwards */
>-    if (qemuCaps->version >= 1003000)
>-        virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT);
>-
>     /*
>      * Handling of -incoming arg with varying features
>      *  -incoming tcp    (kvm >= 79, qemu >= 0.10.0)
>--
>1.8.3.2
>

ACK,

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140418/dabff55d/attachment-0001.sig>


More information about the libvir-list mailing list