[libvirt] [PATCH 03/18] util: storage: Don't force path canonicalization when loading metadata

Eric Blake eblake at redhat.com
Wed Apr 23 12:07:53 UTC 2014


On 04/23/2014 01:59 AM, Peter Krempa wrote:

>>> -    if (!(canonPath = canonicalize_file_name(path)) &&
>>> -        VIR_STRDUP(canonPath, path) < 0) {
>>> -        virReportSystemError(errno, _("unable to resolve '%s'"), path);
>>> +    if (virStorageIsFile(path)) {
>>
>> You are suggesting this same change in patch 6/18 ... as that patch
>> actually removes this code I'll leave this patch as-is and fix the code
>> in the new helper introduced in 6/18.
> 
> Or I can squash those two commits together (effectively just mention the
> fix in the commit message).

Squashing into one works for me.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140423/1acb2fa6/attachment-0001.sig>


More information about the libvir-list mailing list