[libvirt] [PATCHv2 2/4] network: change location of network state xml files

[Eric Blake]

On 04/24/2014 04:30 AM, Laine Stump wrote:

>>>
>> ACK; however... Your call if you want to wait for virDirRead() from:
>>
>> http://www.redhat.com/archives/libvir-list/2014-April/msg00745.html
>>
>> Then refactor your for (;;) loop to use it...
> 
> I think I would rather push it as-is, then send a separate patch to
> switch to virDirRead() (unless ncopa adds that to his series). The
> reason I'd rather keep it separate is to decrease the number of
> prerequisite patches in case this one is backported.

Based on that thread, it looks like ncopa wasn't planning on doing any
more conversions; I've started the work of finishing his series, and
will post it later today.  I agree with your approach of pushing your
patch first without virDirRead, and then saving the conversion to that
new patch.  At any rate, my conversion to virDirRead adds a syntax check
so we won't forget.  And in the worst case, if virDirRead goes in first,
the series is intentionally divided to provide the new function in one
patch, then convert a few files at a time, then add the syntax check
last, so that it's easy to backport just the new function and one or two
conversions without the syntax check, if needed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140424/d5072cdb/attachment-0001.sig>