[libvirt] [libvirt-glib] [PATCH 0/4] Add more snapshot API

Christophe Fergeau cfergeau at redhat.com
Tue Aug 5 10:29:32 UTC 2014


Hey,

On Sat, Aug 02, 2014 at 10:41:45AM +0200, mail at baedert.org wrote:
> From: Timm Bäder <mail at baedert.org>
> 
> The following 4 patches add some more snapshot API to libvirt-glib.
> 
> I wasn't sure where to put _revert_to really, the libvirt API sounds
> like it belongs into GVirDomain (i.e. gvir_domain_revert_to_snapshot),
> but virDomainRevertToSnapshot only takes a pointer to the snapshot.

Snapshot XML which you get from libvirt contains a "domain" node with
the full domain configuration at the time the snapshot was created, and
I think the current domain configuration will be reverted to the
configuration stored in the snapshot when we revert to it.
I think it's ok to have this under GVirDomainSnapshot. If we put that in
GVirDomain, we'd have to make sure the snapshot we are trying to revert
to corresponds to the domain we are acting on.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140805/8e6c04e2/attachment-0001.sig>


More information about the libvir-list mailing list