[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: Format interface's driver more frequently



On 08/11/2014 03:02 PM, Michal Privoznik wrote:
> There's this <driver/> element under <interface/> which can have
> several attributes. However, the driver element is currently formated
> only if the driver's name or txmode has been specified. This makes
> only a little sense as we parse even partial <driver/>, for instance:
> 
>     <interface type='user'>
>       <mac address='52:54:00:e5:48:58'/>
>       <model type='virtio'/>
>       <driver ioeventfd='on' event_idx='on' queues='5'/>
>     </interface>
> 
> But such XML would never get formatted back.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/conf/domain_conf.c                             |  4 +-
>  .../qemuxml2argv-interface-driver.xml              | 51 ++++++++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  1 +
>  3 files changed, 55 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-interface-driver.xml

ACK

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]