[libvirt] [PATCHv2] iotune: setting an invalid value now reports error

Erik Skultety eskultet at redhat.com
Tue Aug 26 07:52:27 UTC 2014


Thanks.

Erik

On 08/25/2014 04:48 PM, Ján Tomko wrote:
> On 08/25/2014 10:50 AM, Erik Skultety wrote:
>> When trying to set an invalid value into iotune element, standard
>> behavior was to not report any error, rather to reset all affected
>> subelements of the iotune element back to 0 which results in ignoring
>> those particular subelements by XML generator. Patch further
>> examines the return code of the virXPathULongLong function
>> and in case of an invalid non-integer value raises an error.
>> Fixed to preserve consistency with invalid value checking
>> of other elements.
>>
>> Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1131811
>> ---
>>   src/conf/domain_conf.c | 67 ++++++++++++++++++++++++++++++++++++--------------
>>   1 file changed, 49 insertions(+), 18 deletions(-)
>
> ACK and pushed.
>
> Jan
>
>
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>




More information about the libvir-list mailing list