[libvirt] [PATCH] Update LIBVIRT_CHECK_LIB and LIBVIRT_CHECK_LIB_ALT to use pkg-config

Daniel P. Berrange berrange at redhat.com
Fri Dec 5 10:07:07 UTC 2014


On Thu, Dec 04, 2014 at 01:41:10PM -0700, Eric Blake wrote:
> On 12/04/2014 01:30 PM, Pavel Hrdina wrote:
> > For example on FreeBSD the "yajl" library is located at "/usr/local/lib"
> > and it's not in default LIBS and therefore the configure fails that
> > "yajl" not installed.
> > 
> > We can use the "PKG_CHECK_MODULES" to get the correct library path in
> > case the library provides pkg-config file definition, otherwise the old
> > approach is used.
> 
> This feels a bit awkward.  Shouldn't we instead be fixing
> m4/virt-yajl.m4 to use LIBVIRT_CHECK_PKG?  That is, shouldn't yajl be
> using pkg-config everywhere, and not just on FreeBSD?

I'm not sure that older versions of yajl actually use pkg-config - if
they did I'm sure I would have used PKG_CHECK_MODULES in the first
place.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list