[libvirt] [PATCH 00/12] more progress towards backing chain allocation stats

Eric Blake eblake at redhat.com
Sat Dec 6 08:14:08 UTC 2014


This is in response to my earlier v2 patch attempt at exposing
qcow2 allocation watermarks during a block commit (although that
series attempted to expand virDomainGetXMLDesc, while this one
expands virDomainListGetStats instead):
https://www.redhat.com/archives/libvir-list/2014-November/msg00589.html

It is also a followup to my preliminiaries (where I had review
comments to split patch 2/2, now 3 separate patches in this series):
https://www.redhat.com/archives/libvir-list/2014-November/msg00932.html

There's enough new content here that I didn't know whether to call
this a v3 of the original approach, but as the original approach was
rejected on design without much review, it feels like this is a new
series, even if a couple of patches from the v2 series ended up in
this series in a slightly different form.

See patch 12 for a sample of the planned output; I still have a few
more patches to polish to properly get qemu JSON output wired into
the command for correct values, but this should at least be sufficient
to write up client code that interacts with the interface.

The patches can also be grabbed from:
git fetch git://repo.or.cz/libvirt/ericb.git getstats

or browsed at:
http://repo.or.cz/w/libvirt/ericb.git/tree/refs/heads/getstats

Eric Blake (12):
  getstats: avoid memory leak on OOM
  getstats: improve documentation
  qemu: refactor blockinfo job handling
  qemu: let blockinfo reuse virStorageSource
  qemu: refactor blockinfo data gathering
  getstats: start giving offline block stats
  getstats: report block sizes for offline domains
  getstats: add block.n.path stat
  getstats: prepare for dynamic block.count stat
  getstats: add new flag for block backing chain
  getstats: split block stats reporting for easier recursion
  getstats: start crawling backing chain for qemu

 include/libvirt/libvirt-domain.h |   1 +
 src/libvirt-domain.c             |  24 ++-
 src/qemu/qemu_driver.c           | 415 ++++++++++++++++++++++++++-------------
 src/util/virstoragefile.h        |   3 +-
 tools/virsh-domain-monitor.c     |   7 +
 tools/virsh.pod                  |  10 +-
 6 files changed, 315 insertions(+), 145 deletions(-)

-- 
1.9.3




More information about the libvir-list mailing list