[libvirt] [PATCH v2 2/2] virsh: Don't reconnect after the command when disconnected

[Martin Kletzander]

On Fri, Dec 05, 2014 at 12:32:28PM +0100, Jiri Denemark wrote:
>On Mon, Dec 01, 2014 at 12:00:53 +0100, Martin Kletzander wrote:
>> Each command that needs a connection causes a new connection to be
>> made.  Reconnecting after a command failed is pointless, mainly when
>> there is no other command to run.  Removeing three lines of code takes
>> care of that and keeps virsh working as it should.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  tools/virsh.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/tools/virsh.c b/tools/virsh.c
>> index bcfa561..0ead9ae 100644
>> --- a/tools/virsh.c
>> +++ b/tools/virsh.c
>> @@ -1958,9 +1958,6 @@ vshCommandRun(vshControl *ctl, const vshCmd *cmd)
>>          if (!ret)
>>              vshReportError(ctl);
>>
>> -        if (!ret && disconnected != 0)
>> -            vshReconnect(ctl);
>> -
>>          if (STREQ(cmd->def->name, "quit") ||
>>              STREQ(cmd->def->name, "exit"))        /* hack ... */
>>              return ret;
>
>ACK
>

Pushed, thanks.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141208/388af07b/attachment-0001.sig>