[libvirt] [PATCH 0/2]qemu: output error when try to hotplug/coldplug a unsupported device

Luyao Huang lhuang at redhat.com
Tue Dec 9 06:48:54 UTC 2014


When use attach-device to hotplug a qemu unsupported console, command
will success and add a XML to the running guest, but donnot do anything
in qemu side. Add a check in qemuBuildConsoleChrDeviceStr, and output a
error when try to attach a qemu unsupport console.

About report error for qemu unsupported Chr device when cold-plug,
I think this maybe unnessary in this place, because we will check it
when we start the guest and it will report a clear error.But if we
use qemu* header func add a qemu unsupported things to qemu guest, it seems
strange.

Luyao Huang (2):
  qemu: output error when try to hotplug unsupport console
  qemu: add a check when cold-plug a Chr device

 src/qemu/qemu_command.c |  6 ++++-
 src/qemu/qemu_hotplug.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 69 insertions(+), 1 deletion(-)

-- 
1.8.3.1




More information about the libvir-list mailing list