[libvirt] [PATCH 2/3] qemu: Free saved error in qemuDomainSetVcpusFlags

[Eric Blake]

On 12/16/2014 12:13 PM, Martin Kletzander wrote:
> Commit e3435caf added cleanup code to qemuDomainSetVcpusFlags() that was
> not supposed to reset the error.  Usual procedure was done, saving the
> error to temporary variable, but it was never free'd, but rather leaked.
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 1 +
>  1 file changed, 1 insertion(+)

ACK

> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 7211d42..9aba4c8 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -4781,6 +4781,7 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus,
>          err = virSaveLastError();
>          virCgroupSetCpusetMems(cgroup_temp, mem_mask);
>          virSetError(err);
> +        virFreeError(err);
>      }
> 
>      if (!qemuDomainObjEndJob(driver, vm))
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141216/e626fefa/attachment-0001.sig>