[libvirt] [PATCH v2 06/12] qemu: fix bugs in blockstats

[Eric Blake]

On 12/17/2014 04:57 AM, John Ferlan wrote:
> 
> 
> On 12/16/2014 06:53 PM, Eric Blake wrote:
>> On 12/16/2014 06:17 AM, John Ferlan wrote:
>>>
>>> Ran the series through my local Coverity checker.... found one issue....
>>>

>> I didn't see an explicit ACK on this patch, but as 7/12 is the same
>> material just refactored, I'll go ahead and push the corrected form of
>> this at the same time as that one.
>>
> Coverity complained this morning because there's a call to
> virStorageFileGetMetadataFromBuf in the block just before this:
> 
> (18) Event alloc_fn: 	Storage is returned from allocation function "virStorageFileGetMetadataFromBuf". [details]
> (19) Event var_assign: 	Assigning: "meta" = storage returned from "virStorageFileGetMetadataFromBuf(src->path, buf, len, format, NULL)".
> (20) Event cond_false: 	Condition "!(meta = virStorageFileGetMetadataFromBuf(src->path, buf, len, format, NULL))", taking false branch
> Also see events: 	[overwrite_var]

Blah. In all my rebasing, I duplicated a line, and indeed caused a
memory leak.  Trivial patch coming up soon.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141217/7e67d041/attachment-0001.sig>