[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/15] esxDriver: Adapt to virDomain{Resume, Suspend}Flags



On 02/03/2014 09:17 AM, Michal Privoznik wrote:
> So far, there are no flags to implement, so just call the
> corresponding function with 0 passed as @flags.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/esx/esx_driver.c | 28 ++++++++++++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)


> +}
> +
> +
> +
> +static int

Why 3 blank lines?

>  esxDomainShutdownFlags(virDomainPtr domain, unsigned int flags)
>  {
>      int result = -1;
> @@ -5203,7 +5225,9 @@ static virDriver esxDriver = {
>      .domainLookupByUUID = esxDomainLookupByUUID, /* 0.7.0 */
>      .domainLookupByName = esxDomainLookupByName, /* 0.7.0 */
>      .domainSuspend = esxDomainSuspend, /* 0.7.0 */
> +    .domainSuspendFlags = esxDomainSuspendFlags, /* 1.2.2 */
>      .domainResume = esxDomainResume, /* 0.7.0 */
> +    .domainResumeFlags = esxDomainResumeFlags, /* 1.2.2 */

Otherwise trivial; and ACK if the concept of 1 and 2 is approved.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]