[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/15] hypervDriver: Adapt to virDomain{Resume, Suspend}Flags



On 02/03/2014 09:17 AM, Michal Privoznik wrote:
> So far, there are no flags to implement, so just call the
> corresponding function with 0 passed as @flags.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/hyperv/hyperv_driver.c | 28 ++++++++++++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)
> 

> +}
> +
> +
> +
> +static int
>  hypervDomainDestroyFlags(virDomainPtr domain, unsigned int flags)

Why 3 blank lines?

>  {
>      int result = -1;
> @@ -1370,7 +1392,9 @@ static virDriver hypervDriver = {
>      .domainLookupByUUID = hypervDomainLookupByUUID, /* 0.9.5 */
>      .domainLookupByName = hypervDomainLookupByName, /* 0.9.5 */
>      .domainSuspend = hypervDomainSuspend, /* 0.9.5 */
> +    .domainSuspendFlags = hypervDomainSuspendFlags, /* 1.2.2 */
>      .domainResume = hypervDomainResume, /* 0.9.5 */
> +    .domainResumeFlags = hypervDomainResumeFlags, /* 1.2.2 */

Otherwise good to go if the concept is approved.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]