[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 2/2] network: change default of forwardPlainNames to 'yes'



On 02/03/2014 08:09 PM, Daniel P. Berrange wrote:
> On Fri, Jan 31, 2014 at 04:25:14PM +0200, Laine Stump wrote:
>> The previous patch fixed "forwardPlainNames" so that it really is
>> doing only what is intended, but left the default to be
>> "forwardPlainNames='no'". Discussion around the initial version of
>> that patch led to the decision that the default should instead be
>> "forwardPlainNames='yes'" (i.e. the original behavior before commit
>> f3886825). This patch makes that change to the default.
>> ---
>>  src/conf/network_conf.c                            | 32 +++++++++++++++-------
>>  src/conf/network_conf.h                            | 17 ++++++++++--
>>  src/network/bridge_driver.c                        |  3 +-
>>  tests/networkxml2confdata/dhcp6-nat-network.conf   |  2 --
>>  tests/networkxml2confdata/dhcp6-network.conf       |  2 --
>>  .../dhcp6host-routed-network.conf                  |  2 --
>>  tests/networkxml2confdata/isolated-network.conf    |  2 --
>>  .../nat-network-dns-forwarders.conf                |  2 --
>>  .../nat-network-dns-srv-record-minimal.conf        |  2 --
>>  .../nat-network-dns-srv-record.conf                |  2 --
>>  .../nat-network-dns-txt-record.conf                |  2 --
>>  tests/networkxml2confdata/nat-network.conf         |  2 --
>>  tests/networkxml2confdata/netboot-network.conf     |  2 --
>>  .../networkxml2confdata/netboot-proxy-network.conf |  2 --
>>  tests/networkxml2confdata/routed-network.conf      |  2 --
>>  tests/networkxml2xmlout/nat-network-dns-hosts.xml  |  2 +-
>>  .../nat-network-dns-more-hosts.xml                 |  2 +-
>>  .../nat-network-no-hosts.xml                       |  1 +
>>  18 files changed, 42 insertions(+), 39 deletions(-)
> ACK
>

Okay, I've pushed both of these. Thanks!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]