[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 1/5] gconfig: Fix gvir_config_domain_os_get_boot_devices() API doc



On Tue, Jan 21, 2014 at 11:42:54AM +0100, Christophe Fergeau wrote:
> The elements of the returned list are integer enum values, so they cannot
> be unreffed.
> ---
>  libvirt-gconfig/libvirt-gconfig-domain-os.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libvirt-gconfig/libvirt-gconfig-domain-os.c b/libvirt-gconfig/libvirt-gconfig-domain-os.c
> index 03c8a85..b922a0e 100644
> --- a/libvirt-gconfig/libvirt-gconfig-domain-os.c
> +++ b/libvirt-gconfig/libvirt-gconfig-domain-os.c
> @@ -267,8 +267,7 @@ static gboolean add_boot_device(xmlNodePtr node, gpointer opaque)
>   * @os: a #GVirConfigDomainOs
>   *
>   * Gets the list of devices attached to @os. The returned list should be
> - * freed with g_list_free(), after its elements have been unreffed with
> - * g_object_unref().
> + * freed with g_list_free().
>   *
>   * Returns: (element-type LibvirtGConfig.DomainOsBootDevice) (transfer full):
>   * a newly allocated #GList of #GVirConfigDomainOsBootDevice.

Do you know if GIR cares about this distinction ? ie should we be changing
'transfer full' to 'transfer container', or is it assumed that these two
annotations are identical when the element type is a scalar (non-object)
type. I'm guessing the distinction doesn't matter, so ACK unless you
know something to the contrary.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]