[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH python] Fix calling of virStreamSend method



On Tue, Feb 04, 2014 at 06:31:26AM -0700, Eric Blake wrote:
> On 02/04/2014 03:21 AM, Daniel P. Berrange wrote:
> > On Mon, Feb 03, 2014 at 02:32:27PM -0700, Eric Blake wrote:
> >> On 01/23/2014 07:25 AM, Daniel P. Berrange wrote:
> >>> Change d40861 removed the 'len' argument from the virStreamSend
> >>> C level wrapper, but forgot to remove it from the python level
> >>> wrapper.
> >>>
> >>> Reported-by: Robie Basak <robie basak canonical com>
> >>> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> >>> ---
> >>>  libvirt-override-virStream.py | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> Hmm, you pushed this patch onto the release before 1.2.1; I had to push
> >> a merge commit to get the master branch to include both this and the
> >> release.  I'm not sure why git let you push a non-fast-forward, unless
> >> DV forgot to push the 1.2.1 tag to the master branch until after you had
> >> already pushed this.
> >
> > That is very odd - the commit dates all show a normal sequence of
> > committing. I can only imagine that perhaps we forgot to set the
> > "deny merge" bit in the git repo config and I wasn't up2date when
> > I pushed ?  The git config looks OK right now, but I see you modified
> > it last night, so did you fix something ?
>
> I had to temporarily disable the "deny merge" to push the merge that
> fixed things, but turned it back on after fixing things and verified
> that the hooks were indeed working as expected.  So I don't know how we
> got in that state; oh well.
>
> By the way, what's the best way to test libvirt-python.git against
> uninstalled libvirt.git?  I'm trying to add bindings for my
> virConnectDomainQemuMonitorEvent patches, but as my system installed
> libvirt is not yet at 1.2.2, I'm not sure the python bindings are
> building my new code.  Could we expand HACKING to give better
> instructions on how to set up a build pointing to uninstalled libvirt?
>

You can change the prefix of the upstream libvirt, install it and then
run setup.py with PKG_CONFIG_PATH changed.  Or you can apply my patch
which was NACKed in this discussion:

http://www.redhat.com/archives/libvir-list/2013-November/msg01127.html

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]