[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemuxml2argvtest: Test localtime clock basis



  Eric Blake wrote:

> On 02/05/2014 07:32 AM, Michal Privoznik wrote:
> > When trying to introduce a test for previous patch, I've
> > noticed that the command line is constructed using current
> > time. This won't work in our test suite (unless you guys
> > wants to set a specific time prior to each test run :) ).
> > Therefore we need to mock calls to time(2) to return the
> > same value every time it's called.
> 
> Slick.  But as we only support mocking calls on Linux, you have
> converted a test from generic platform to Linux-only.  Then again, qemu
> tests only run where we support qemu, which is currently Linux only, so
> I'm not sure it will matter.  I guess we'll find out if anyone complains
> that it broke 'make check' on their platform.

I'm not sure if I have a good understanding of what 'supported' means
here, but at least I can say that qemu driver is 'functional' on FreeBSD
with some known limitations (i.e. missing firewalling part in bridge
driver, etc).

Roman Bogorodskiy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]