[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemuxml2argvtest: Set timezone



On 02/06/2014 03:11 PM, Michal Privoznik wrote:
> With my recent work on the test, both time() and localtime() are used.
> While mocking the former one, we get predictable result for UTC. But
> since the latter function uses timezone to get local time, the result of
> localtime() is not so predictive. Therefore, we must set the TZ variable
> at the beginning of the test. To be able to catch some things that work
> just by a blind chance, I'm choosing a virtual timezone that (hopefully)
> no libvirt developer resides in.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  .../qemuxml2argv-clock-localtime-basis-localtime.args          |  2 +-
>  tests/qemuxml2argvtest.c                                       | 10 ++++++++++
>  2 files changed, 11 insertions(+), 1 deletion(-)

ACK, please push.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]