[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/14] Fix path used for USB device attach with LXC



On 02/07/2014 08:33 AM, Daniel P. Berrange wrote:
> The LXC code missed the 'usb' component out of the path
> /dev/bus/usb/$BUSNUM/$DEVNUM, so it failed to actually
> setup cgroups for the device. This was in fact lucky
> because the call to virLXCSetupHostUsbDeviceCgroup
> was also mistakenly passing '&priv->cgroup' instead of
> just 'priv->cgroup'. So once the path is fixed, libvirtd
> would then crash trying to access the bogus virCgroupPtr
> pointer. This would have been a security issue, were it
> not for the bogus path preventing the pointer reference
> being reached.
> 

One bug masking another.  Eww.

> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/lxc/lxc_driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]