[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/14] Fix reset of cgroup when detaching USB device from LXC guests



On 02/07/2014 08:33 AM, Daniel P. Berrange wrote:
> When detaching a USB device from an LXC guest we must remove
> the device from the cgroup ACL. Unfortunately we were telling
> the cgroup code to use the guest /dev path, not the host /dev
> path, and the guest device node had already been unlinked.
> This was, however, fortunate since the code passed &priv->cgroup
> instead of priv->cgroup, so would have crash if the device node
> were accessible.

Another case of one bug masking another.  Wow.

> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/lxc/lxc_driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]