[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 14/14] Avoid unsafe use of /proc/$PID/root in LXC hotunplug code



On 02/07/2014 08:33 AM, Daniel P. Berrange wrote:
> Rewrite multiple hotunplug functions to to use the
> virProcessRunInMountNamespace helper. This avoids
> risk of a malicious guest replacing /dev with a absolute
> symlink, tricking the driver into changing the host OS
> filesystem.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/lxc/lxc_driver.c | 79 ++++++++++++++++++++++++++--------------------------
>  1 file changed, 39 insertions(+), 40 deletions(-)
> 

>  static int
> +lxcDomainAttachDeviceUnlinkHelper(pid_t pid ATTRIBUTE_UNUSED,
> +                                  void *opaque)
> +{
> +    const char *path = opaque;
> +
> +    VIR_DEBUG("Unlinking %s", path);
> +    if (unlink(path) < 0 && errno != ENOENT) {
> +        virReportSystemError(errno,
> +                             _("Unable to remove device %s"), path);

Same generic concern about _() using malloc in an async-safe context,
but not worth worrying about in this patch.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]