[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/11] libxl: add job support



On Tue, Feb 11, 2014 at 03:36:15PM +0100, Michal Privoznik wrote:
> On 07.02.2014 04:53, Jim Fehlig wrote:
> >This patch series adds job support to the libxl driver, using techiques from
> >the qemu driver.  One benefit is no longer blocking get operations during
> >long running modify operations.  E.g. with these patches 'vish dominfo dom'
> >will work while 'virsh save dom ...' is in progress.
> >
> >The first patch adds the job support machinery, followed by several patches
> >that make use of it.  I initially had all but the first in a single
> >"use-job-support" patch, but hope breaking it out eases review.
> >
> >Jim Fehlig (11):
> >   libxl: Add job support to libxl driver
> >   libxl: use job functions in libxlVmStart
> >   libxl: use job functions in libxlDomainSetMemoryFlags
> >   libxl: use job functions in libxlDomain{Suspend,Resume}
> >   libxl: use job functions in libxlDomainDestroyFlags
> >   libxl: use job functions in domain save operations
> >   libxl: use job functions in libxlDomainCoreDump
> >   libxl: use job functions in vcpu set and pin functions
> >   libxl: use job functions in device attach and detach functions
> >   libxl: use job functions in libxlDomainSetAutostart
> >   libxl: use job functions in libxlDomainSetSchedulerParametersFlags
> >
> >  src/libxl/libxl_domain.c | 128 ++++++++++++++++++
> >  src/libxl/libxl_domain.h |  37 +++++
> >  src/libxl/libxl_driver.c | 346 +++++++++++++++++++++++++++++++----------------
> >  3 files changed, 395 insertions(+), 116 deletions(-)
> >
> 
> Aha! This needs to be applied on the top of your 'misc trivial
> cleanups' set.
> 
> The last time I've tried to introduce job control to the storage
> driver, it got rejected as it duplicated a lot of code from the qemu
> driver. Somebody suggested to rip the job control out into a
> separate unit so the code could be shared. Having said that, I'll
> review the patches, but please take my ACKs as 'code is okay' not
> permission to push. I'd rather see somebody else giving ACK to the
> design.

We could definitely use some shared module for job control APIs.
I didn't want to put too much burden on Jim right now though, since
we've still not merged the large PCI shared API work we asked for
wrt libxl + hostdev support. So figured shared job control could
be done as a followup.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]