[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 21/21] blkiotune: allow <node major='' minor=''/> in place of <path>



On Wed, Feb 05, 2014 at 03:10:19PM +0100, Cédric Bosdonnat wrote:
> To ease LXC configuration conversion, allow blkiotune device XML
> fragments to define the device using its major:minor numbers.
> ---
>  docs/formatdomain.html.in                       |  10 +-
>  src/conf/domain_conf.c                          |  45 ++++++++-
>  src/conf/domain_conf.h                          |   2 +
>  src/lxc/lxc_cgroup.c                            |   5 +
>  src/lxc/lxc_driver.c                            |  10 ++
>  src/lxc/lxc_native.c                            |  24 ++++-
>  src/qemu/qemu_cgroup.c                          |   5 +
>  src/qemu/qemu_driver.c                          |  10 ++
>  src/util/vircgroup.c                            | 126 ++++++++++--------------
>  src/util/vircgroup.h                            |  10 ++
>  tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml |   4 +-
>  11 files changed, 165 insertions(+), 86 deletions(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index fd02864..2ab7d39 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -761,6 +761,10 @@
>        &lt;path&gt;/dev/sdb&lt;/path&gt;
>        &lt;weight&gt;500&lt;/weight&gt;
>      &lt;/device&gt;
> +    &lt;device&gt;
> +      &lt;node major='8' minor='0'/&gt;
> +      &lt;weight&gt;500&lt;/weight&gt;
> +    &lt;/device&gt;
>    &lt;/blkiotune&gt;

I realize this is helping the conversion of existing configs, but
personally I'm pretty loathe to add this syntax. With device paths
it is possible to have stable paths ie using /dev/disk/by*. With
major/minor the XML configuration is not portable across hosts or
even stable  within a host since major numbers are fairly arbitrarily
assigned with hotpluggable SCSI or networked iSCSI.

Personally I'd list this as one of the things an admin has to fixup
manually post conversion.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]