[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events



On 02/11/2014 08:15 AM, Daniel P. Berrange wrote:

>>> ---
>>>  src/conf/domain_event.c  | 140 +++++++++++++++++++++++++++++++++++++++++++++++
>>>  src/conf/domain_event.h  |  22 ++++++++
>>>  src/libvirt_private.syms |   2 +
>>>  3 files changed, 164 insertions(+)
>>
>> I think these APIs should be in  src/qemu/qemu_event.{c,h} rather
>> than in the shared codebase. I think it ought to be possible to
>> split the code off, since we've already done separation of the
>> network + domain events + base object evemt classes into distinct
>> files.
> 
> Ah, later patches show why this is needed - the remote client driver
> needs access to this API

Yes, but the remote client could just as easily get them from a new file.

I'll go ahead and make the file split (I was 50/50 on whether to create
a new file, and chose the wrong way).

Also, I still need a review on this series, as it is is a prereq to
arbitrary events:
https://www.redhat.com/archives/libvir-list/2014-January/msg01457.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]