[libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

[Eric Blake]

On 02/11/2014 08:28 AM, Daniel P. Berrange wrote:
> On Tue, Feb 11, 2014 at 08:26:50AM -0700, Eric Blake wrote:
>> On 02/11/2014 08:15 AM, Daniel P. Berrange wrote:
>>
>>>>> ---
>>>>>  src/conf/domain_event.c  | 140 +++++++++++++++++++++++++++++++++++++++++++++++
>>>>>  src/conf/domain_event.h  |  22 ++++++++
>>>>>  src/libvirt_private.syms |   2 +
>>>>>  3 files changed, 164 insertions(+)
>>>>
>>>> I think these APIs should be in  src/qemu/qemu_event.{c,h} rather
>>>> than in the shared codebase. I think it ought to be possible to
>>>> split the code off, since we've already done separation of the
>>>> network + domain events + base object evemt classes into distinct
>>>> files.
>>>
>>> Ah, later patches show why this is needed - the remote client driver
>>> needs access to this API
>>
>> Yes, but the remote client could just as easily get them from a new file.
>>
>> I'll go ahead and make the file split (I was 50/50 on whether to create
>> a new file, and chose the wrong way).
> 
> But if we put it in the src/qemu directory this would create complexity
> for our build process when remote driver is enabled but qemu driver is
> disabled.

Oh, I misread.  I was thinking a separate file in src/conf, whereas I
see you were thinking of src/qemu.  Yeah, that does get too difficult.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140211/8eff55d6/attachment-0001.sig>