[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-java] [PATCH 01/65] Fix warnings about using raw types



Hi,

On Thu, Feb 13, 2014 at 04:22:09PM +0100, Claudio Bley wrote:
> Eclipse generates this kind of warning:
> 
> org/libvirt/jna/virConnectCredential.java:20:
> List is a raw type. References to generic type List<E> should be parameterized
> 
> Signed-off-by: Claudio Bley <cbley av-test de>
> ---
>  src/main/java/org/libvirt/jna/virConnectAuth.java  |    4 ++--
>  .../java/org/libvirt/jna/virConnectCredential.java |    4 ++--
>  .../java/org/libvirt/jna/virDomainBlockInfo.java   |    4 ++--
>  .../java/org/libvirt/jna/virDomainBlockStats.java  |    4 ++--
>  src/main/java/org/libvirt/jna/virDomainInfo.java   |    4 ++--
>  .../org/libvirt/jna/virDomainInterfaceStats.java   |    4 ++--
>  .../java/org/libvirt/jna/virDomainJobInfo.java     |    4 ++--
>  .../java/org/libvirt/jna/virDomainMemoryStats.java |    4 ++--
>  src/main/java/org/libvirt/jna/virError.java        |    4 ++--
>  src/main/java/org/libvirt/jna/virNodeInfo.java     |    4 ++--
>  .../java/org/libvirt/jna/virSchedParameter.java    |    4 ++--
>  .../java/org/libvirt/jna/virStoragePoolInfo.java   |    4 ++--
>  .../java/org/libvirt/jna/virStorageVolInfo.java    |    4 ++--
>  src/main/java/org/libvirt/jna/virVcpuInfo.java     |    4 ++--
>  14 files changed, 28 insertions(+), 28 deletions(-)
> 
> diff --git a/src/main/java/org/libvirt/jna/virConnectAuth.java b/src/main/java/org/libvirt/jna/virConnectAuth.java
> index ece61f6..0451348 100644
> --- a/src/main/java/org/libvirt/jna/virConnectAuth.java
> +++ b/src/main/java/org/libvirt/jna/virConnectAuth.java
> @@ -15,11 +15,11 @@ public class virConnectAuth extends Structure {
>      public Libvirt.VirConnectAuthCallback cb;
>      public Pointer cbdata;
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "credtype", "ncredtype", "cb", "cbdata");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virConnectCredential.java b/src/main/java/org/libvirt/jna/virConnectCredential.java
> index 6dd4a75..316b1f4 100644
> --- a/src/main/java/org/libvirt/jna/virConnectCredential.java
> +++ b/src/main/java/org/libvirt/jna/virConnectCredential.java
> @@ -17,12 +17,12 @@ public class virConnectCredential extends Structure implements Structure.ByRefer
>      public String result;
>      public int resultlen;
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "type", "prompt", "challenge", "defresult",
>              "result", "resultlen");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virDomainBlockInfo.java b/src/main/java/org/libvirt/jna/virDomainBlockInfo.java
> index fb1b845..5a88ba3 100644
> --- a/src/main/java/org/libvirt/jna/virDomainBlockInfo.java
> +++ b/src/main/java/org/libvirt/jna/virDomainBlockInfo.java
> @@ -10,11 +10,11 @@ public class virDomainBlockInfo extends Structure {
>      public long allocation;
>      public long physical;
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "capacity", "allocation", "physical");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virDomainBlockStats.java b/src/main/java/org/libvirt/jna/virDomainBlockStats.java
> index a7331f6..e48629a 100644
> --- a/src/main/java/org/libvirt/jna/virDomainBlockStats.java
> +++ b/src/main/java/org/libvirt/jna/virDomainBlockStats.java
> @@ -20,11 +20,11 @@ public class virDomainBlockStats extends Structure {
>      public long errs; // this is a long long in the code, so a long mapping is
>      // correct
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "rd_req", "rd_bytes", "wr_req", "wr_bytes", "errs");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virDomainInfo.java b/src/main/java/org/libvirt/jna/virDomainInfo.java
> index 0b667f6..ff20d16 100644
> --- a/src/main/java/org/libvirt/jna/virDomainInfo.java
> +++ b/src/main/java/org/libvirt/jna/virDomainInfo.java
> @@ -16,11 +16,11 @@ public class virDomainInfo extends Structure {
>      public short nrVirtCpu;
>      public long cpuTime;
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "state", "maxMem", "memory", "nrVirtCpu", "cpuTime");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virDomainInterfaceStats.java b/src/main/java/org/libvirt/jna/virDomainInterfaceStats.java
> index eea6a49..9b98aa8 100644
> --- a/src/main/java/org/libvirt/jna/virDomainInterfaceStats.java
> +++ b/src/main/java/org/libvirt/jna/virDomainInterfaceStats.java
> @@ -26,12 +26,12 @@ public class virDomainInterfaceStats extends Structure {
>      public long tx_drop; // this is a long long in the code, so a long mapping
>      // is correct
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "rx_bytes", "rx_packets", "rx_errs", "rx_drop",
>              "tx_bytes", "tx_packets", "tx_errs", "tx_drop");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virDomainJobInfo.java b/src/main/java/org/libvirt/jna/virDomainJobInfo.java
> index 0398901..1bab587 100644
> --- a/src/main/java/org/libvirt/jna/virDomainJobInfo.java
> +++ b/src/main/java/org/libvirt/jna/virDomainJobInfo.java
> @@ -19,13 +19,13 @@ public class virDomainJobInfo extends Structure {
>      public long fileProcessed;
>      public long fileRemaining;
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "type", "timeElapsed", "timeRemaining", "dataTotal",
>              "dataProcessed", "dataRemaining", "memTotal", "memProcessed",
>              "memRemaining", "fileTotal", "fileProcessed", "fileRemaining");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virDomainMemoryStats.java b/src/main/java/org/libvirt/jna/virDomainMemoryStats.java
> index b14fb95..dfbd3f9 100644
> --- a/src/main/java/org/libvirt/jna/virDomainMemoryStats.java
> +++ b/src/main/java/org/libvirt/jna/virDomainMemoryStats.java
> @@ -9,10 +9,10 @@ public class virDomainMemoryStats extends Structure {
>      public int tag ;
>      public long val ;
>  
> -    private static final List fields = Arrays.asList( "tag", "val");
> +    private static final List<String> fields = Arrays.asList( "tag", "val");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virError.java b/src/main/java/org/libvirt/jna/virError.java
> index 36b9f69..e58f5f3 100644
> --- a/src/main/java/org/libvirt/jna/virError.java
> +++ b/src/main/java/org/libvirt/jna/virError.java
> @@ -22,12 +22,12 @@ public class virError extends Structure {
>      public int int2;
>      public NetworkPointer net;
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "code", "domain", "message", "level", "conn", "dom",
>              "str1", "str2", "str3", "int1", "int2", "net");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virNodeInfo.java b/src/main/java/org/libvirt/jna/virNodeInfo.java
> index 9ff1251..7a7716e 100644
> --- a/src/main/java/org/libvirt/jna/virNodeInfo.java
> +++ b/src/main/java/org/libvirt/jna/virNodeInfo.java
> @@ -25,12 +25,12 @@ public class virNodeInfo extends Structure {
>      public int cores;
>      public int threads;
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "model", "memory", "cpus", "mhz", "nodes",
>              "sockets", "cores", "threads");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virSchedParameter.java b/src/main/java/org/libvirt/jna/virSchedParameter.java
> index f579ef0..f3787a9 100644
> --- a/src/main/java/org/libvirt/jna/virSchedParameter.java
> +++ b/src/main/java/org/libvirt/jna/virSchedParameter.java
> @@ -13,11 +13,11 @@ public class virSchedParameter extends Structure {
>      public int type;
>      public virSchedParameterValue value;
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "field", "type", "value");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virStoragePoolInfo.java b/src/main/java/org/libvirt/jna/virStoragePoolInfo.java
> index fe20f0f..7077175 100644
> --- a/src/main/java/org/libvirt/jna/virStoragePoolInfo.java
> +++ b/src/main/java/org/libvirt/jna/virStoragePoolInfo.java
> @@ -17,11 +17,11 @@ public class virStoragePoolInfo extends Structure {
>      public long available; // this is a long long in the code, so a long mapping
>      // is correct
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "state", "capacity", "allocation", "available");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virStorageVolInfo.java b/src/main/java/org/libvirt/jna/virStorageVolInfo.java
> index 93132ea..8bf2d5c 100644
> --- a/src/main/java/org/libvirt/jna/virStorageVolInfo.java
> +++ b/src/main/java/org/libvirt/jna/virStorageVolInfo.java
> @@ -15,11 +15,11 @@ public class virStorageVolInfo extends Structure {
>      public long allocation; // this is a long long in the code, so a long
>      // mapping is correct
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "type", "capacity", "allocation");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }
> diff --git a/src/main/java/org/libvirt/jna/virVcpuInfo.java b/src/main/java/org/libvirt/jna/virVcpuInfo.java
> index 96eca2f..bc1a539 100644
> --- a/src/main/java/org/libvirt/jna/virVcpuInfo.java
> +++ b/src/main/java/org/libvirt/jna/virVcpuInfo.java
> @@ -15,11 +15,11 @@ public class virVcpuInfo extends Structure {
>      // is correct
>      public int cpu;
>  
> -    private static final List fields = Arrays.asList(
> +    private static final List<String> fields = Arrays.asList(
>              "number", "state", "cpuTime", "cpu");
>  
>      @Override
> -    protected List getFieldOrder() {
> +    protected List<String> getFieldOrder() {
>          return fields;
>      }
>  }

ACK (from a non Java expert).
 -- Guido


> -- 
> 1.7.9.5
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]