[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 2/4] remote: Implement remote{Get,Set}Time



On Thu, Feb 13, 2014 at 07:51:43PM +0100, Michal Privoznik wrote:
> This is also adding new ACL permission to check 'set_time'.
>
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  daemon/remote.c              | 35 +++++++++++++++++++++++++++++++++++
>  src/access/viraccessperm.c   |  2 +-
>  src/access/viraccessperm.h   |  6 ++++++
>  src/remote/remote_driver.c   | 32 ++++++++++++++++++++++++++++++++
>  src/remote/remote_protocol.x | 31 ++++++++++++++++++++++++++++++-
>  src/remote_protocol-structs  | 16 ++++++++++++++++
>  6 files changed, 120 insertions(+), 2 deletions(-)
>
> diff --git a/daemon/remote.c b/daemon/remote.c
> index 932f65f..8020e60 100644
> --- a/daemon/remote.c
> +++ b/daemon/remote.c
> @@ -6027,3 +6027,38 @@ error:
>      }
>      return -1;
>  }
> +
> +static int
> +remoteDispatchDomainGetTime(virNetServerPtr server ATTRIBUTE_UNUSED,
> +                            virNetServerClientPtr client,
> +                            virNetMessagePtr msg ATTRIBUTE_UNUSED,
> +                            virNetMessageErrorPtr rerr,
> +                            remote_domain_get_time_args *args,
> +                            remote_domain_get_time_ret *ret)
> +{
> +    int rv = -1;
> +    virDomainPtr dom = NULL;
> +    struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client);
> +    long long time;
> +

Applies to previous patch too, this 'time' will be a problem with
'-Wshadow-declarations' on older (some) compilers.

ACK with that variable name changed.

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]