[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v12 01/11] change used_by: specify both driver and domain



On 02/17/2014 10:31 AM, Cedric Bosdonnat wrote:
>> --- a/src/util/virpci.c
>> > +++ b/src/util/virpci.c
>> > @@ -59,7 +59,10 @@ struct _virPCIDevice {
>> >      char          name[PCI_ADDR_LEN]; /* domain:bus:slot.function */
>> >      char          id[PCI_ID_LEN];     /* product vendor */
>> >      char          *path;
>> > -    const char    *used_by;           /* The domain which uses the device */
>> > +
>> > +    /* The driver:domain which uses the device */
>> > +    char          *used_by_drvname;
>> > +    char          *used_by_domname;
> Why changing from const char* to char*?
>

Just guessing that it's due to paranoia about the original string
disappearing. I can possibly understand that for used_by_domname, but
used_br_drvname is always a constant from a #define, so it's probably
not necessary.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]