[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv6 4/5] vbox_tmpl.c: Patch for redefining snapshots



On Thu, Jan 23, 2014 at 10:28:32AM +0100, Manuel VIVES wrote:
> The snapshots are saved in xml files, and then can be redefined
> ---
>  src/vbox/vbox_tmpl.c | 1083 +++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 1075 insertions(+), 8 deletions(-)

My comment here is that you ought to separate the XML handling
out from the driver. Create a new file vbox_snapshot_conf.{c,h}
In the header define a struct containing the data to be saved
in the XML. Then provide an API for writing the struct to an
XML doc, and another API for reading the XML to create a struct.
Then the vbox_tmpl.c would call those methods.

Also, a bit more info about the XML format in the commit message
would be useful. In particular i'm unclear if this XML document
is something you're inventing specifically for use by libvirt
here, or is a format the VirtualBox itself has defined.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]