[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Rename virDomainGetRootFilesystem to virDomainGetFilesystemForTarget



On 12/18/2013 05:22 AM, Daniel P. Berrange wrote:

Wow, this one has sat for a while.

> The virDomainGetRootFilesystem method can be generalized to allow
> any filesystem path to be obtained.
> 
> While doing this, start a new test case for purpose of testing various
> helper methods in the domain_conf.{c,h} files, such as this one.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---

> +++ b/src/lxc/lxc_container.c
> @@ -1823,7 +1823,7 @@ static int lxcContainerChild(void *data)
>      if (lxcContainerSetID(vmDef) < 0)
>          goto cleanup;
>  
> -    root = virDomainGetRootFilesystem(vmDef);
> +    root = virDomainGetFilesystemForTarget(vmDef, "/");
>  

Looks okay to me.

> +++ b/tests/domainconftest.c
> @@ -0,0 +1,120 @@
> +/*
> + * Copyright (C) 2013 Red Hat, Inc.

You may want to add 2014 to the new files.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]