[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 07/10] Add unit test for virCgroupGetBlkioIo*Serviced



On 14.02.2014 18:49, Thorsten Behrens wrote:
---
Notes to v4:
  - share fake disk device path via header file instead of env var

  tests/testutilslxc.h  |   3 ++
  tests/vircgroupmock.c |  98 +++++++++++++++++++++++++++++++++++++-
  tests/vircgrouptest.c | 129 ++++++++++++++++++++++++++++++++++++++++++++++++++
  3 files changed, 228 insertions(+), 2 deletions(-)

diff --git a/tests/testutilslxc.h b/tests/testutilslxc.h
index ee8056f..aa0730e 100644
--- a/tests/testutilslxc.h
+++ b/tests/testutilslxc.h
@@ -1,4 +1,7 @@

  #include "capabilities.h"

+# define FAKEDEVDIR0 "/fakedevdir0/bla/fasl"
+# define FAKEDEVDIR1 "/fakedevdir1/bla/fasl"
+

No need for the space in between '#' and 'define' as you're not in ifdef block. In fact, syntax-check raised an error here.

  virCapsPtr testLXCCapsInit(void);

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]