[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 06/10] Widening API change - accept empty path for virDomainBlockStats



On 02/20/2014 08:26 AM, Michal Privoznik wrote:
> On 14.02.2014 18:49, Thorsten Behrens wrote:
>> And provide domain summary stat in that case, for lxc backend.
>> Use case is a container inheriting all devices from the host,
>> e.g. when doing application containerization.
>> ---
>>   src/libvirt.c                |  8 ++++++--
>>   tools/virsh-domain-monitor.c | 11 ++++++++---
>>   tools/virsh.pod              |  5 +++--
>>   3 files changed, 17 insertions(+), 7 deletions(-)
> 
> Very wise! We unfortunately can't allow NULL here as it would require
> RPC change (and thus a new API - we have no upstream experience with
> introducing a new version on RPC :))

Actually, we do: as of 1.2.2, virConnectDomainEventRegisterAny is the
first API that knows how to manage 2 versions of the underlying RPC
call.  But yeah, we don't want to make a habit of doing fork-brained RPC
calls.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]