[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] virsh: common code for parsing --seconds



On Fri, Feb 14, 2014 at 05:21:38PM -0700, Eric Blake wrote:
> Several virsh commands ask for a --timeout parameter in
> seconds, then use it to control interfaces that operate on
> millisecond limits; I also plan on adding a 'virsh event'
> command that also does this.  Factor this into a common
> function.
> 
> * tools/virsh.h (vshCommandOptTimeoutToMs): New prototype.
> * tools/virsh.c (vshCommandOptTimeoutToMs): New function.
> * tools/virsh-domain.c (cmdBlockCommit, cmdBlockCopy)
> (cmdBlockPull, cmdMigrate): Use it.
> (vshWatchJob): Adjust timeout scale.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  tools/virsh-domain.c | 72 ++++++++++------------------------------------------
>  tools/virsh.c        | 26 ++++++++++++++++++-
>  tools/virsh.h        |  4 ++-
>  3 files changed, 42 insertions(+), 60 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]