[libvirt] [libvirt-java] [PATCH 17/65] Remove processError from Domain class

Daniel P. Berrange berrange at redhat.com
Fri Feb 21 10:44:42 UTC 2014


On Thu, Feb 13, 2014 at 04:22:25PM +0100, Claudio Bley wrote:
> Wrap any fallible libvirt function in a call to ErrorHandler.processError(..).
> 
> Also update erroneous javadoc comments stating that methods would return a
> value in case an error occurs.  In case of a libvirt error, a
> LibvirtException is thrown.
> 
> Add processErrorIfZero(long) to ErrorHandler class to handle special
> libvirt return codes, such as for virDomainGetMaxMemory. Use it in
> Domain.getMaxMemory().
> 
> Signed-off-by: Claudio Bley <cbley at av-test.de>
> ---
>  src/main/java/org/libvirt/Domain.java       |  328 +++++++++------------------
>  src/main/java/org/libvirt/ErrorHandler.java |    5 +
>  2 files changed, 113 insertions(+), 220 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list