[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 1/2] tests: Move EXTRA_DIST back into ENABLE_TESTS conditional



On Mon, Feb 24, 2014 at 12:56:21PM +0100, Christophe Fergeau wrote:
> When deciding which files to put into the make dist tarball, automake is
> clever enough to ignore conditional blocks, and to pick all files which are
> needed for all values of the conditional.
> 
> Having EXTRA_DIST=xxx at the beginning of tests/Makefile.am causes
> warnings from automake when ENABLE_TESTS is true as glib-tap.mk will
> unconditionally empty it.
> 
> Keeping EXTRA_DIST+=xxx outside of the ENABLE_TESTS conditional would
> cause a different warning from automake when ENABLE_TESTS is false as
> we'd be appending to a variable which was never set.
> 
> Moving EXTRA_DIST+= back into the conditional solves these 2 warnings.
> ---
>  tests/Makefile.am | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]