[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] virsh: kill over-engineered asprintf failure recovery



On 02/24/2014 10:42 AM, Michal Privoznik wrote:
> On 21.02.2014 23:59, Eric Blake wrote:
>> I noticed this while shortning switch statements via VIR_ENUM.
>> Basically, the only ways virAsprintf can fail are if we pass a
>> bogus format string (but we're not THAT bad) or if we run out
>> of memory (but it already warns on our behalf in that case).
>> Throw away the cruft that tries too hard to diagnose a printf
>> failure.
>>
>> * tools/virsh-volume.c (cmdVolList): Simplify.
>> * tools/virsh-pool.c (cmdPoolList): Likewise.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>   tools/virsh-pool.c   | 73
>> +++++++++++++++++-----------------------------------
>>   tools/virsh-volume.c | 66
>> ++++++++++++++---------------------------------
>>   2 files changed, 42 insertions(+), 97 deletions(-)
> 
> ACK

Thanks; I pushed the series.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]