[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] gluster: Fix "key" attribute for gluster volumes



On 02/24/2014 08:21 AM, Peter Krempa wrote:
> According to our documentation the "key" value has the following
> meaning: "Providing an identifier for the volume which is globally
> unique. This cannot be set when creating a volume: it is always
> generated." The currently used keys for gluster volumes consist of the
> gluster volume name and file path. This can't be considered unique as a
> different storage server can serve a volume with the same name.
> 
> Use the full URI as the key for the volume to avoid ambiguity problems.

The full URI cannot be considered unique, either, as both
gluster://hosta/volume/file and gluster://hostb/volume/file may resolve
to the same file.  I think we are better off documenting that a key is
unique for some pools, but best effort for others, and not change what
we have already been outputting.  But if we DO keep this patch, you also
need to change the documentation that gives examples of gluster keys.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]