[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] virNetServerRun: Notify systemd that we're accepting clients

On 02/25/2014 08:33 AM, Michal Privoznik wrote:

>> Adds a new configure option, but doesn't change the spec file.  This is
>> bad, because it means that someone doing 'make rpm' now has an
>> indeterminate behavior based on whether they have the library installed.
>>   We need a followup patch.
> Not necessarily true. We already have:
> BuildRequires: systemd-devel >= 185

Ah, but that only occurs inside %{with_udev}.  We need to hoist that
outside, as we now have a usage of systemd-devel that is independent of
whether we are also using udev.  It's also good form to modify the
%configure line in the spec file to explicitly state our expectations,
rather than implicitly relying on things, even if the build happens to
always implicitly choose correctly based on BuildRequires.

At any rate, since I pointed it out, I don't mind working on the followup.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]